-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Publish private branch 'dev-msi-Microsoft.ManagedIdentity-2022-01-31-preview-federated-identities' #19548
Conversation
…2018-11-30 to version 2022-01-31-preview
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/5106 |
Hi, @isolenov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
The child tracked resource, 'federatedIdentityCredentials' with immediate parent 'Identity', must have a list by immediate parent operation. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L612 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.ManagedIdentity/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L70 |
R4037 - MissingTypeObject |
The schema 'Identity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L596 |
R4037 - MissingTypeObject |
The schema 'IdentityUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L628 |
R4037 - MissingTypeObject |
The schema 'SystemAssignedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L664 |
R4037 - MissingTypeObject |
The schema 'UserAssignedIdentitiesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L864 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L880 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L890 |
R4037 - MissingTypeObject |
The schema 'OperationDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L932 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L958 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L905 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L962 |
Guid used in model definition 'SystemAssignedIdentityProperties' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L708 |
|
Guid used in model definition 'UserAssignedIdentityProperties' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L738 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: MsiOperationsList Location: Microsoft.ManagedIdentity/preview/2022-01-31-preview/ManagedIdentity.json#L74 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
"readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
💬 | "readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"AutoRest core version selected from configuration: ^3.2.0." |
💬 | "readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)" |
💬 | "readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)" |
💬 | "readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)" |
💬 | "readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)" |
💬 | "readme":"msi/resource-manager/readme.md", "tag":"package-preview-2022-01", "details":"Autorest completed in 11.42s. 0 files generated." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi, @isolenov your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{resourceName}/listAssociatedResources": { | ||
"post": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this was approved in an earlier review so this is fine.
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{resourceName}/federatedIdentityCredentials": { | ||
"get": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt appear to have any secrets so this is fine. Also this was approved earlier
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.